Skip to content

countryfetch: set OPENSSL_NO_VENDOR env var#392746

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
Defelo:countryfetch
Mar 28, 2025
Merged

countryfetch: set OPENSSL_NO_VENDOR env var#392746
GaetanLepage merged 1 commit intoNixOS:masterfrom
Defelo:countryfetch

Conversation

@Defelo
Copy link
Member

@Defelo Defelo commented Mar 24, 2025

Set the OPENSSL_NO_VENDOR environment variable instead of manually removing the vendored feature from openssl

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 24, 2025
@Defelo
Copy link
Member Author

Defelo commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392746

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/14039560258

Download packages from cache:
  • x86_64-linux 
    nix-store -r --add-root nixpkgs-pr-392746-x86_64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/9hhai9yka9psmc0rddgc489jmnlvrxr3-countryfetch-0.1.9
  • aarch64-linux 
    nix-store -r --add-root nixpkgs-pr-392746-aarch64-linux \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/zszx6lam66c8s3f7g4v81lqin74nksjs-countryfetch-0.1.9
  • x86_64-darwin 
    nix-store -r --add-root nixpkgs-pr-392746-x86_64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/2qgrdhzzp0hznyfa9zpqvqcss2vm8cpz-countryfetch-0.1.9
  • aarch64-darwin 
    nix-store -r --add-root nixpkgs-pr-392746-aarch64-darwin \
  --option binary-caches 'https://cache.nixos.org/ https://attic.defelo.de/nixpkgs' \
  --option trusted-public-keys '
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  nixpkgs:xeaAWa3crK09hMmFiygBeRmLq3hUjUShgaAwYVUEtw0=
  ' \
  /nix/store/336pga1x85vchgky0f30b6820s611nhb-countryfetch-0.1.9

x86_64-linux

✅ 1 package built:
  • countryfetch

aarch64-linux

✅ 1 package built:
  • countryfetch

x86_64-darwin

✅ 1 package built:
  • countryfetch

aarch64-darwin

✅ 1 package built:
  • countryfetch

@Defelo Defelo added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Mar 24, 2025
GaetanLepage
GaetanLepage approved these changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@GaetanLepage GaetanLepage merged commit d02923b into NixOS:master Mar 28, 2025
28 checks passed
@Defelo Defelo deleted the countryfetch branch March 28, 2025 08:45
@GaetanLepage
Copy link
Contributor

GaetanLepage commented Mar 28, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 392746

Logs: https://github.com/GaetanLepage/nixpkgs-review-gha/actions/runs/14125070391

x86_64-linux

✅ 1 package built:
  • countryfetch

aarch64-linux

✅ 1 package built:
  • countryfetch

x86_64-darwin

✅ 1 package built:
  • countryfetch

aarch64-darwin

✅ 1 package built:
  • countryfetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Defelo @GaetanLepage

Comments